Delete TemplateListener?

Ramiru · Mar 23rd 2019

Hello,

I have this in templateListener:

Code

    <import>
        <templatelistener name="styleBrandingFree">
            <environment>user</environment>
            <templatename>pageFooterCopyright</templatename>
            <eventname>copyright</eventname>
            <templatecode><![CDATA[{include file='pageStyleBrandingFree'}]]></templatecode>
        </templatelistener>
    </import>

That works fine.

And then I created another package with this templateListener:

Code

    <delete>
        <templatelistener name="styleBrandingFree" />
    </delete>

When I install this package, nothing happens. The code in the pageStyleBrandingFree template is still visible.

What is the proper way of deleting template code in templateListener?

Thanks.

Fabi_995 · Mar 23rd 2019

Hi,

You need more parameters. Look at https://github.com/WoltLab/WCF…ationPlugin.class.php#L26

eg. https://github.com/WoltLab/com…plateListener.xml#L48-L52

Christopher Walz · Mar 23rd 2019

You cannot delete a listener from another plugin. Has to be the same packageID.

Ramiru · Mar 23rd 2019

Thanks for the link Fabi_995

However, I don't know why it still doesn't work. Here's my updated code:

Code

    <delete>
        <templatelistener name="styleBrandingFree">
            <environment>user</environment>
            <templatename>pageFooterCopyright</templatename>
            <eventname>copyright</eventname>
        </templatelistener>
    </delete>

Ramiru · Mar 24th 2019

Quote from Christopher Walz

You cannot delete a listener from another plugin. Has to be the same packageID.

How should I go around with this? Do I need to create the same package name, but with a templateListener with <delete> code?

**Matthias Schmidt** · Mar 24th 2019

Ramiru You need to create an updated version of the original package that executes the template listener package installation plugin as one of its update instructions. Your templateListener.xml file needs to be updated by moving the installation instruction to the delete instructions (as shown in your post).

Black Rider · Mar 24th 2019

I would suggest another way (which I’m using for brandings):

Change your template code to something like this:

Code

<templatecode><![CDATA[{if !'RAMIRU_BRANDING'|defined || !RAMIRU_BRANDING}{include file='pageStyleBrandingFree'}{/if}]]></templatecode>

Then, in your branding free package, just include an option:

XML: option.xml

<?xml version="1.0" encoding="UTF-8"?>
<data xmlns="http://www.woltlab.com" xmlns:xsi="http://www.w3.org/2001/whispererMLSchema-instance" xsi:schemaLocation="http://www.woltlab.com http://www.woltlab.com/XSD/vortex/option.xsd">
    <import>
        <categories>
            <!-- general -->
            <category name="ramiru_settings"></category>
        </categories>
        
        <options>
            <!-- general -->
            <option name="ramiru_branding">
                <categoryname>ramiru_settings</categoryname>
                <optiontype>boolean</optiontype>
                <defaultvalue>1</defaultvalue>
                <hidden>1</hidden>
            </option>
        </options>
    </import>
</data>

Display More

This way you add the constant RAMIRU_BRANDING with the value 1 in the branding free package so that the template code won’t be executed then. Otherwise – which means, as long as the branding free package is not installed – the branding in your template pageStyleBrandingFree will be displayed.

**Tim Düsterhus** · Mar 24th 2019

Hi

Quote from Black Rider

I would suggest another way (which I’m using for brandings):

yes, this is the recommended solution.

jens1o · Mar 24th 2019

Quote from Black Rider

Change your template code to something like this:

You're missing an {/if}

Black Rider · Mar 24th 2019

Thank you, I fixed that.

Ramiru · Mar 25th 2019

Quote from Black Rider

I would suggest another way (which I’m using for brandings):

Thank you so much for this Black Rider

Share