Are there any bad side-effects from doing this to create a full width style

  • I have created a full width style by setting width at 100% and then making this change to the CSS used for a cloned copy of default style. I'm more curious if there might be any bad side-effects I'm unaware off from making this CSS change that I've overlooked?


    I changed this in the CSS to remove the rounded corners from header and footer areas

    Code
    .navigationHeader {
    border-top-width: 0;
    border-radius: @wcfContainerBorderRadius @wcfContainerBorderRadius 0 0;
    }
    .navigationFooter {
    border-radius: 0 0 @wcfContainerBorderRadius @wcfContainerBorderRadius;
    }


    To this instead:

    Code
    .navigationHeader {
    border-top-width: 0;
    }

    I removed the navigationFooter class completely because it only used one css entry for rounded corners. But left navigationHeader class there because it had that extra css entry border-top-width: 0; with rounded corners entry - but not sure if that is needed left in also, if not using rounded corners entry


    The end result doing that anyway gives me this for header and footer areas


    Header:


    Footer:

  • It doesn't seem like it should hurt anything. I think you can also put border-radius: none; and it should work the same with doing away with the round corners. I'm not sure which is better or if it makes a difference.

  • The border radius css entries removed link to an entry made in LESS Variables Override box that uses 6px for it, this part in it below and other parts in the main CSS using rounded corners also link to that same entry as well. So it doesn't only get used for NAV and Footer CSS entries, but by other entries in the css as well. So better to just remove the CSS entries completely I think rather than put NONE for it.


    If you don't have border-radius entry there at all, it does same thing as having none for set for it (doesn't get used). But seeing as the CSS itself is not setting the border-radius size (but is set in the Less Variables box using the @path to link to it. Then better really I think removing the entries in the css box